Change in vdsm[master]: v2v: add format for disk conversion

shavivi at redhat.com shavivi at redhat.com
Sun May 3 10:48:13 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: v2v: add format for disk conversion
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40343/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 416:                                    (self._id, event))
Line 417: 
Line 418:     def _create_command(self):
Line 419:         fmt = self._vminfo.get('format', 'raw')
Line 420:         cmd = [_VIRT_V2V.cmd, '-ic', self._uri, '-o', 'vdsm', '-of', fmt]
> The fmt parameter is not very useful, maybe:
Done
Line 421:         cmd.extend(self._generate_disk_parameters())
Line 422:         cmd.extend(['--password-file',
Line 423:                     self._passwd_file,
Line 424:                     '--vdsm-vm-uuid',


-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list