Change in vdsm[master]: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.

danken at redhat.com danken at redhat.com
Fri May 1 08:53:42 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/39324/4/vdsm/caps.py
File vdsm/caps.py:

Line 686:     caps['liveMerge'] = str(getLiveMergeSupport()).lower()
Line 687:     caps['kdumpStatus'] = _getKdumpStatus()
Line 688: 
Line 689:     caps['hostdevPassthrough'] = str(_getHostdevPassthorughSupport()).lower()
Line 690:     caps['additionalFeatures'] = []
I don't think that we need another level of nesting.
We can set

 caps['glusterSnaption'] = True

just like what we do with hostdevPassthrough or liveSnapSupported.
Line 691:     if _glusterEnabled:
Line 692:         caps['additionalFeatures'].extend(_getGlusterAdditionalFeatures())
Line 693:     return caps
Line 694: 


-- 
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list