Change in vdsm[master]: Live Merge: work around racy libvirt pivot

danken at redhat.com danken at redhat.com
Tue Mar 31 20:59:32 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Live Merge: work around racy libvirt pivot
......................................................................


Live Merge: work around racy libvirt pivot

Libvirt version 1.2.8-16.el7_1.2 introduced a bug where the synchronous
call to blockJobAbort (which we use to pivot to the new leaf after an
active layer merge completes) will return before the domain XML has been
updated.  This makes it look like the pivot failed when it actually
succeeded.  This means that vdsm state will not be properly synchronized
and we may start the vm with a stale volume in the future which will
corrupt the VM's storage.  See
https://bugzilla.redhat.com/show_bug.cgi?id=1202719 for more details.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206722
Change-Id: I1e794622baf66c75cbe583be03a7b9a4a7e4883d
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39303
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 44 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Adam Litke: Verified
  Dan Kenigsberg: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/39303
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e794622baf66c75cbe583be03a7b9a4a7e4883d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list