Change in vdsm[master]: functional tests: add basic device verification
fromani at redhat.com
fromani at redhat.com
Tue Mar 31 15:55:23 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: functional tests: add basic device verification
......................................................................
Patch Set 4:
(2 comments)
nice work. Concept is fine, some issues with naming. Let's try to improve
https://gerrit.ovirt.org/#/c/38980/4/tests/Makefile.am
File tests/Makefile.am:
Line 31: clientifTests.py \
Line 32: concurrentTests.py \
Line 33: configNetworkTests.py \
Line 34: cpuProfileTests.py \
Line 35: devices.py \
Don't really like the naming.
I think it is not the time for to reorganize the structure of tests/* - we have too much rolling already.
A good short/mid term solutions could be to reverse the naming and add a 'verify.py' (verification? asserts? -lib?)
and do
verify.devices
instead of
devices.verify
this way, it is meaningful enough with everything under tests/*, and looks forward compatible enough
Line 36: deviceTests.py \
Line 37: domainDescriptorTests.py \
Line 38: executorTests.py \
Line 39: fileSDTests.py \
https://gerrit.ovirt.org/#/c/38980/4/tests/devices.py
File tests/devices.py:
Line 23:
Line 24: def verify(device_conf=None, device_objects=None,
Line 25: assert_in_fn=lambda *_: False,
Line 26: assert_true_fn=lambda *_: False,
Line 27: assert_equal_fn=lambda *_: False):
for some reasons I'm not enthusiast about those names either.
Btw, do we need defaults here?
Line 28: if device_conf is not None:
Line 29: aliases = []
Line 30: for device in device_conf:
Line 31: # Graphics device is a bit specific in a sense that it doesn't
--
To view, visit https://gerrit.ovirt.org/38980
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ca6630ad047fbc1d9b036e1112bf5db41dc24d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list