Change in vdsm[master]: xmlrpc: detecting loop on centos7
fromani at redhat.com
fromani at redhat.com
Tue Mar 31 15:28:27 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: xmlrpc: detecting loop on centos7
......................................................................
Patch Set 4:
(1 comment)
initial review, one question inside.
https://gerrit.ovirt.org/#/c/39343/4/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:
Line 95: self.handle_connect_event()
Line 96:
Line 97: self.handle_read()
Line 98:
Line 99: if hasattr(self.__impl, "recently_detected"):
for my understanding: how it is possible for __impl *not* to have this attribute?
Line 100: if self.__impl.recently_detected():
Line 101: return
Line 102:
Line 103: # we need to check whether there is pending function on
--
To view, visit https://gerrit.ovirt.org/39343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list