Change in vdsm[master]: Live Merge: work around racy libvirt pivot

fromani at redhat.com fromani at redhat.com
Tue Mar 31 14:18:45 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: Live Merge: work around racy libvirt pivot
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/39303/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5139:             # is ongoing.  If we are still in this loop when the VM is powered
Line 5140:             # off, the merge will be resolved manually by engine using the
Line 5141:             # reconcileVolumeChain verb.
Line 5142:             chains = self.vm._driveGetActualVolumeChain([self.drive])
Line 5143:             if alias not in chains.keys():
> no good reason :)  I'll respin if necessary.
please don't respin for such a silly nit :)
Line 5144:                 raise RuntimeError("Failed to retrieve volume chain for "
Line 5145:                                    "drive %s.  Pivot failed.", alias)
Line 5146:             curVols = sorted([entry.uuid for entry in chains[alias]])
Line 5147: 


-- 
To view, visit https://gerrit.ovirt.org/39303
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e794622baf66c75cbe583be03a7b9a4a7e4883d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list