Change in vdsm[master]: virt: periodic: port queryBlockJobs

alitke at redhat.com alitke at redhat.com
Tue Mar 31 13:28:01 UTC 2015


Adam Litke has posted comments on this change.

Change subject: virt: periodic: port queryBlockJobs
......................................................................


Patch Set 32:

I like the concept but I'll need to run this through some testing before I can approve it.  Especially want to verify vdsm restarts during block jobs and other negative flows.

Is this framework resilient against other periodic functions throwing exceptions?  In the past, other stats functions were breaking live merge when they threw exceptions resulting in queryBlockJobs never being called.

-- 
To view, visit https://gerrit.ovirt.org/37595
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list