Change in vdsm[master]: virt: sampling: add StatsCache

fromani at redhat.com fromani at redhat.com
Tue Mar 31 12:36:43 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: sampling: add StatsCache
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/39331/2/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 423:             self._last_sample_time = monotonic_ts
Line 424:         else:
Line 425:             self._log.warning('dropped stale old sample')
Line 426: 
Line 427:     def _fetch(self, vmid, batch, timestamp):
was unused here and needed by followup patch. Removed from here, and changed the followup patch.
Line 428:         if batch is None:
Line 429:             sample = None
Line 430:         else:
Line 431:             sample = batch.get(vmid)


-- 
To view, visit https://gerrit.ovirt.org/39331
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d5069f49d54bb5f43a7c4914c7e4b9f8093db9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list