Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Tue Mar 31 11:54:21 UTC 2015
Michal Skrivanek has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
......................................................................
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/37509/15/vdsm/v2v.py
File vdsm/v2v.py:
Line 358: self._proc.returncode)
Line 359: return
Line 360: raise
Line 361: time.sleep(self.ABORT_DELAY)
Line 362: logging.error("Error killing virt-v2v (pid: %d)", self._proc.pid)
if we happen to kill it with SIGKILL we need to remove the temporary files ourselves. rm -rf /var/run/vdsm/v2v? Or just do this in the cleanup patch on vdsm startup...we have to do it anyway, so why not only once over there.
Line 363: zombiereaper.autoReapPID(self._proc.pid)
Line 364:
Line 365: def _generate_disk_parameters(self):
Line 366: parameters = []
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list