Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

nsoffer at redhat.com nsoffer at redhat.com
Tue Mar 31 11:01:09 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 15:

(2 comments)

https://gerrit.ovirt.org/#/c/37509/15/vdsm/v2v.py
File vdsm/v2v.py:

Line 350:                     return
Line 351:                 logging.debug("Trying to kill virt-v2v (attempt %d/%d)",
Line 352:                               i + 1, self.ABORT_RETRIES)
Line 353:                 try:
Line 354:                     self._proc.kill()
> it makes sense to send SIGTERM several times - but not SIGKILL
This is sanlock algorithm for killing processes. Maybe not be needed but I don't see any harm in sending new signal on each iteration, and it is very simple.
Line 355:                 except OSError as e:
Line 356:                     if e.errno == errno.ESRCH:
Line 357:                         logging.debug("virt-v2v terminated with exit code: %d",
Line 358:                                       self._proc.returncode)


Line 370:                 parameters.append(disk['imageID'])
Line 371:                 parameters.append('--vdsm-vol-uuid')
Line 372:                 parameters.append(disk['volumeID'])
Line 373:             except KeyError as e:
Line 374:                 raise InvalidInput('Missing required property: %s' % e)
> I see no point in this exception translatoin, but if Nir wants it, let it b
The point is raising an error that makes it easy to debug.

And this is not really a translation, we could right:

    if 'imageID' not in disk:
        raise ...

But this requires more code for no value.
Line 375:         return parameters
Line 376: 
Line 377:     def _prepare_volumes(self):
Line 378:         if len(self._vm_properties['disks'] < 1):


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list