Change in vdsm[master]: virt: numa: move activation check in the caller

danken at redhat.com danken at redhat.com
Tue Mar 31 10:53:40 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: numa: move activation check in the caller
......................................................................


virt: numa: move activation check in the caller

The existing NUMA position reporting code is activated
only if a VM is configured with 'virtual NUMA', referred
in the code as 'guest Numa Node'.
If this configuration is absent, the NUMA sampling just
does nothing.

Besides naming, this makes the code a bit harder to read
and to reason about, since often readers assume NUMA positioning
reporting always executed.

To make this easier to read, and to make room for future patches
which want to move NUMA sampling in periodic operations,
we move this check into the calling site(s), with no other intended
changes in the flow of code.

Change-Id: Ib1b94c2b45b0cbd4455d4fff719b932173536af3
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39261
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/numaUtilsTests.py
M vdsm/numaUtils.py
M vdsm/virt/vm.py
3 files changed, 23 insertions(+), 17 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/39261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1b94c2b45b0cbd4455d4fff719b932173536af3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list