Change in vdsm[master]: multipath: Wait for udev events after rescan

danken at redhat.com danken at redhat.com
Tue Mar 31 09:32:13 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: multipath: Wait for udev events after rescan
......................................................................


multipath: Wait for udev events after rescan

Previously we were using time.sleep(2) for waiting at least 2 seconds
after starting iSCSI sessions rescan. This wait was useless for two
reasons:
- The sleep was interrupted as soon as iscsiadm process terminated
- Udev events generated by the SCSI scan and by processing udev rules
  may not been handled yet when iscsiadm existed.

This patch replaces the minimal scsi timeout with udevadm.settle(),
waiting until current udev events are handled.  Since we perform both FC
and iSCSI scan, the correct place for waiting is in multipath.rescan()
and not in iscsi.rescan().

A new configuration was introduced, allowing fine tuning of settle
timeout in the field.

    [irs]
    scsi_settle_timeout = 5

Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae
Relates-To: https://bugzilla.redhat.com/1205877
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39288
Reviewed-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Tested-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/config.py.in
M vdsm/storage/iscsi.py
M vdsm/storage/multipath.py
3 files changed, 17 insertions(+), 25 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/39288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list