Change in vdsm[master]: v2v: Job related actions

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Mar 31 08:13:34 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: v2v: Job related actions
......................................................................


Patch Set 1:

(1 comment)

I have no problem to make this non-v2v specific jobs infra. But I really don't want to wander off into all the persistence/recovery issues. Not needed for v2v. We can keep evolving it but please try to focus on the v2v feature first

https://gerrit.ovirt.org/#/c/39361/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 167: 
Line 168: def get_converted_vm(job_id):
Line 169:     try:
Line 170:         job = _get_job(job_id)
Line 171:         _validate_job_done(job)
> Good point,
I don't care what happens on restart as long as we have consistent data. Do we have the cleanup on startup? So we know that there is no job in progress, so then if there is an ovf file we know *for sure* it's completed? If so then we can return it. In all other cases we can just remove the partial file. Crash is not a normal situation, we don't have to recover or anything like that for v2v flows
Line 172:         ovf = _read_ovf(job_id)
Line 173:     except V2VError as e:
Line 174:         logging.warning('Converted VM error %s', e)
Line 175:         return errCode[e.err_name]


-- 
To view, visit https://gerrit.ovirt.org/39361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list