Change in vdsm[master]: xmlrpc: detecting loop on centos7

ybronhei at redhat.com ybronhei at redhat.com
Tue Mar 31 07:05:43 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: xmlrpc: detecting loop on centos7
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/39343/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 101:                 return
Line 102: 
Line 103:         # we need to check whether there is pending function on
Line 104:         # our fd because we use eventfds which do not provide it
Line 105:         if hasattr(self.socket, "pending"):
> The difference is that xmlrpc is already handled differently. Jsonrpc is pr
well, call it xmlprc_detected instead of general name as "recently_detected" and explain in a comment that handle pending buffers should be avoided in this case (and why)
Line 106:             while self.socket.pending() > 0 and self.connected:
Line 107:                 self.handle_read()
Line 108: 
Line 109:     def recv(self, buffer_size):


-- 
To view, visit https://gerrit.ovirt.org/39343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list