Change in vdsm[ovirt-3.5]: vdsm: Fix memory leak in netlink.py

danken at redhat.com danken at redhat.com
Mon Mar 30 22:10:54 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Fix memory leak in netlink.py
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Thanks again for the research and suggested fix. This patch should be first resolved on the master branch.

https://gerrit.ovirt.org/#/c/39372/1/lib/vdsm/netlink.py
File lib/vdsm/netlink.py:

Line 63: link_get_by_name
based only on cursory review of the libnl docs, it seems that this function too requires refcount maintenance.


-- 
To view, visit https://gerrit.ovirt.org/39372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e4dc72bd77e46ba4f95dd8a622f5c3288115315
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: John Taylor <jtt77777 at yahoo.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list