Change in vdsm[master]: Live Merge: work around racy libvirt pivot

alitke at redhat.com alitke at redhat.com
Mon Mar 30 19:30:07 UTC 2015


Adam Litke has posted comments on this change.

Change subject: Live Merge: work around racy libvirt pivot
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/39303/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5136:             # reconcileVolumeChain verb.
Line 5137:             chains = self.vm._driveGetActualVolumeChain([self.drive])
Line 5138:             try:
Line 5139:                 curVols = chains[alias]
Line 5140:             except KeyError:
> Lest use:
Done
Line 5141:                 raise RuntimeError("Failed to retrieve volume chain for "
Line 5142:                                    "drive:%s.  Pivot failed.")
Line 5143:             if len(curVols) < len(origVols):
Line 5144:                 self.vm.log.debug("The XML update has been completed")


Line 5139:                 curVols = chains[alias]
Line 5140:             except KeyError:
Line 5141:                 raise RuntimeError("Failed to retrieve volume chain for "
Line 5142:                                    "drive:%s.  Pivot failed.")
Line 5143:             if len(curVols) < len(origVols):
> I think we need more specific check of the chain:
Done
Line 5144:                 self.vm.log.debug("The XML update has been completed")
Line 5145:                 break
Line 5146:             time.sleep(1)
Line 5147: 


-- 
To view, visit https://gerrit.ovirt.org/39303
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e794622baf66c75cbe583be03a7b9a4a7e4883d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list