Change in vdsm[master]: Skip netdev probe from sessions missing iscsi sysfs (i.e. us...

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 30 19:05:52 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using hardware iSCSI)
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/38354/5/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 126: 
Line 127:     try:
Line 128:         iscsi_host = getIscsiHostPath(sessionID)
Line 129:         netdev = os.path.join(iscsi_host, "netdev")
Line 130:     except NoSessionPath:
> You did not address my concern about no host path - how do we know that thi
Not having session path seems to be good check, but we need to look at some machines with hardware iscsi to be sure.
Line 131:         netdev = None
Line 132: 
Line 133:     if not os.path.isdir(iscsi_session) or not os.path.isdir(iscsi_connection):
Line 134:         raise OSError(errno.ENOENT, "No such session")


Line 127:     try:
Line 128:         iscsi_host = getIscsiHostPath(sessionID)
Line 129:         netdev = os.path.join(iscsi_host, "netdev")
Line 130:     except NoSessionPath:
Line 131:         netdev = None
> else:
I think I meant:

    else:
        netdev = os.path.join(iscsi_host, "netdev")
Line 132: 
Line 133:     if not os.path.isdir(iscsi_session) or not os.path.isdir(iscsi_connection):
Line 134:         raise OSError(errno.ENOENT, "No such session")
Line 135: 


-- 
To view, visit https://gerrit.ovirt.org/38354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list