Change in vdsm[master]: multipath: Wait for udev events after rescan

danken at redhat.com danken at redhat.com
Mon Mar 30 19:04:29 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: multipath: Wait for udev events after rescan
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39288/1//COMMIT_MSG
Commit Message:

Line 14:   may not been handled yet when iscsiadm existed.
Line 15: 
Line 16: This patch replaces the minimal scsi timeout with udevadm.settle(),
Line 17: waiting until current udev events are handled.  Since we perform both FC
Line 18: and iSCSI scan, the correct place for waiting is in multipath.rescan()
> Previously we "waited" after iscsi scan, so I could replace the time.sleep(
ok, that what I understood.
Line 19: and not in iscsi.rescan().
Line 20: 
Line 21: A new configuration was introduced, allowing fine tuning of settle
Line 22: timeout in the field.


-- 
To view, visit https://gerrit.ovirt.org/39288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list