Change in vdsm[master]: fileUtils: Remove bogus warning from log [2/2]

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 30 17:52:10 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: fileUtils: Remove bogus warning from log [2/2]
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/37003/1/vdsm/storage/fileUtils.py
File vdsm/storage/fileUtils.py:

Line 148
Line 149
Line 150
Line 151
Line 152
> do you want to remove this line?
The log debug? No, I want a debug message to make it easier to understand what the system is doing.


Line 150:         statinfo = os.stat(dirPath)
Line 151:         if not stat.S_ISDIR(statinfo.st_mode):
Line 152:             raise OSError(errno.ENOTDIR, "Not a directory %s" % dirPath)
Line 153:         log.debug("Using existing directory: %s", dirPath)
Line 154:         warnings.warn("Using existing direcotory: %s" % dirPath, stacklevel=2)
> sp. directory
Done
Line 155:         if mode is not None:
Line 156:             curMode = stat.S_IMODE(statinfo.st_mode)
Line 157:             if curMode != mode:
Line 158:                 raise OSError(errno.EPERM,


-- 
To view, visit https://gerrit.ovirt.org/37003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list