Change in vdsm[master]: v2v: introduction to OutputParser

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 30 15:34:35 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: introduction to OutputParser
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39360/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 39:     ''' Unexpected error while parsing libvirt domain xml '''
Line 40: 
Line 41: 
Line 42: class OutputParserError(ValueError):
Line 43:     ''' Error while parsing virt-v2v output '''
This should inherit from V2VError - please introduce that error in this patch.

You want it to inherit from V2VError so you can handle all expected errors in one place.
Line 44: 
Line 45: 
Line 46: def supported():
Line 47:     return not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL)


-- 
To view, visit https://gerrit.ovirt.org/39360
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54f3d610d704d0b922e38073edcc813cbc27fe83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list