Change in vdsm[master]: Don't prepare image with illegal volumes

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 30 14:48:44 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Don't prepare image with illegal volumes
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39302/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3225:         if leafUUID not in imgVolumes:
Line 3226:             raise se.VolumeDoesNotExist(leafUUID)
Line 3227: 
Line 3228:         for volUUID in imgVolumes:
Line 3229:             legality = dom.produceVolume(imgUUID, volUUID).getLegality()
> we tried hard to avoid single-volume productions like these, as they cause 
Lets time this with and without the legality check before trying to optimize this.
Line 3230:             if legality == volume.ILLEGAL_VOL:
Line 3231:                 raise se.prepareIllegalVolumeError(volUUID)
Line 3232: 
Line 3233:         imgPath = dom.activateVolumes(imgUUID, imgVolumes)


-- 
To view, visit https://gerrit.ovirt.org/39302
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list