Change in vdsm[master]: jsonrpc: Properly log and return an error if the threadFacto...

danken at redhat.com danken at redhat.com
Mon Mar 30 11:17:06 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpc: Properly log and return an error if the threadFactory fails
......................................................................


jsonrpc: Properly log and return an error if the threadFactory fails

Otherwise if scheduling fails there will be a thread error and no
messages will be handled while VDSM still runs.

Change-Id: I8b579fa0e95397f1dc3b3e939a9040dc5bdef36d
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/35936
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Yeela Kaplan <ykaplan at redhat.com>
Tested-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/yajsonrpc/__init__.py
1 file changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Verified; Looks good to me, but someone else must approve
  Yeela Kaplan: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/35936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b579fa0e95397f1dc3b3e939a9040dc5bdef36d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list