Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
nsoffer at redhat.com
nsoffer at redhat.com
Mon Mar 30 11:16:40 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
......................................................................
Patch Set 14:
(3 comments)
https://gerrit.ovirt.org/#/c/37509/14/vdsm/v2v.py
File vdsm/v2v.py:
Line 123: ''' Unknown parsing event caught '''
Line 124:
Line 125:
Line 126: class InvalidInput(ValueError):
Line 127: ''' Invalid input received '''
> What do you mean?
Validating input when getting would be best.
Line 128:
Line 129:
Line 130: def supported():
Line 131: return not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL)
Line 339:
Line 340: self._proc.blocking = True
Line 341: self._watch_process_output()
Line 342:
Line 343: if self._proc.returncode != 0:
> we added a wait,
If you waited for the process, this line is correct.
Line 344: raise V2VProcessError('Process failed exit-code: %r, stderr: %s' %
Line 345: (self._proc.returncode,
Line 346: self._proc.stderr.read(1024)))
Line 347: logging.info('Importing VM finish, JobId:', self._id)
Line 487: class OutputParser(object):
Line 488: COPY_DISK_RE = re.compile(r'.*(Copying disk (\d+)/(\d+)).*')
Line 489: DISK_PROGRESS_RE = re.compile(r'\s+\((\d+).*')
Line 490:
Line 491: def parse(self, stream):
> I will separate to few patches:
+1
Line 492: for line in stream:
Line 493: if 'Copying disk' in line:
Line 494: description, current_disk, disk_count = self._parse_line(line)
Line 495: yield ImportProgress(int(current_disk), int(disk_count),
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list