Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient

danken at redhat.com danken at redhat.com
Mon Mar 30 11:16:31 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpc: Fix callMethod in JsonRpcClient
......................................................................


jsonrpc: Fix callMethod in JsonRpcClient

In order to call a verb using JsonRpcClient we have several methods that
we can use. We can call method asynchronosuly (call_async) or
synchronously (call). callMethod help with building JsonRpcRequest and
raises an Error in case of any issues occuring on the other side.
callMethod was using call_batch which is not needed so we have decided
to merge both methods and get rid of call_batch as well as fix issues
around single vs batch.

Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: https://gerrit.ovirt.org/35935
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/yajsonrpc/__init__.py
1 file changed, 4 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/35935
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list