Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

danken at redhat.com danken at redhat.com
Sun Mar 29 20:58:26 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 14: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/37509/14/vdsm/v2v.py
File vdsm/v2v.py:

Line 487: class OutputParser(object):
Line 488:     COPY_DISK_RE = re.compile(r'.*(Copying disk (\d+)/(\d+)).*')
Line 489:     DISK_PROGRESS_RE = re.compile(r'\s+\((\d+).*')
Line 490: 
Line 491:     def parse(self, stream):
it would be simpler to review the code if you introduce this parsing functions (and their tests) in a separate patch. There we can discuss whether to keep this OutputParser namespace.
Line 492:         for line in stream:
Line 493:             if 'Copying disk' in line:
Line 494:                 description, current_disk, disk_count = self._parse_line(line)
Line 495:                 yield ImportProgress(int(current_disk), int(disk_count),


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list