Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 29 10:38:08 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped
......................................................................


Prevent systemd to kill dhclient once vdsm-network service is stopped

When upgrading VDSM or for that matter, stopping vdsm-network process,
systemd would kill all the descendants of the service (including dhclient).
When vdsm-network starts again, it discovers /var/run/vdsm/nets_restored and
does not restore any network, possibly leaving the system with interfaces
that have an IP with a timer but no dhclient to renew it. Adding
KillMode=Process tells systemd to only kill the service main process and
nothing more.

Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc
Bug-Url: https://bugzilla.redhat.com/1204782
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39137
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39213
---
M init/systemd/vdsm-network.service.in
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Ido Barkan: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39213
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list