Change in vdsm[master]: storage: Stop using tempnam in deleteImage

nsoffer at redhat.com nsoffer at redhat.com
Sat Mar 28 17:12:37 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: Stop using tempnam in deleteImage
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38768/3/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 363: 
Line 364:     def deleteImage(self, sdUUID, imgUUID, volsImgs):
Line 365:         currImgDir = self.getImagePath(imgUUID)
Line 366:         dirName, baseName = os.path.split(currImgDir)
Line 367:         toDelDir = os.path.join(dirName, sd.REMOVED_IMAGE_PREFIX + baseName)
This breaks our udev rules for removed volumes - we should update the rules to support both old and new patterns.
Line 368:         self.log.debug("Renaming dir %s to %s", currImgDir, toDelDir)
Line 369:         try:
Line 370:             self.oop.os.rename(currImgDir, toDelDir)
Line 371:         except OSError as e:


-- 
To view, visit https://gerrit.ovirt.org/38768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ff87e735c12c94d704391286d1bfc451b442956
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list