Change in vdsm[master]: hsm: Pep8ize function name

nsoffer at redhat.com nsoffer at redhat.com
Sat Mar 28 01:08:23 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: hsm: Pep8ize function name
......................................................................

hsm: Pep8ize function name

Remove unneeded _private prefix for inner function and use lowercase
name.

Change-Id: I54715971378319a8501a49cb89b24f27e50a07f4
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/39306/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index a4bb858..8f75a39 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2070,7 +2070,7 @@
                   boolean
         :rtype: dict
         """
-        def _isVisible(guid):
+        def is_visible(guid):
             path = os.path.join('/dev/mapper', guid)
             try:
                 st = os.stat(path)
@@ -2081,10 +2081,10 @@
             else:
                 return (st.st_mode & stat.S_IRUSR) != 0
 
-        visibility = [_isVisible(guid) for guid in guids]
+        visibility = [is_visible(guid) for guid in guids]
         if not all(visibility):
             multipath.rescan()
-            visibility = [_isVisible(guid) for guid in guids]
+            visibility = [is_visible(guid) for guid in guids]
         visibility = dict(zip(guids, visibility))
 
         # After multipath.rescan, existing devices may disapper, and new


-- 
To view, visit https://gerrit.ovirt.org/39306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54715971378319a8501a49cb89b24f27e50a07f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list