Change in vdsm[master]: vm: Cleaner vm stats thread initialization

nsoffer at redhat.com nsoffer at redhat.com
Fri Mar 27 20:07:10 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: Cleaner vm stats thread initialization
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39299/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1268:         if self._destroyed:
Line 1269:             return
Line 1270:         toSave = self.status()
Line 1271:         toSave['startTime'] = self._startTime
Line 1272:         if self.lastStatus != vmstatus.DOWN:
It was not clear why we check self._vmStats here do we want to know if we started it?
Line 1273:             guestInfo = self.guestAgent.getGuestInfo()
Line 1274:             toSave['username'] = guestInfo['username']
Line 1275:             toSave['guestIPs'] = guestInfo['guestIPs']
Line 1276:             toSave['guestFQDN'] = guestInfo['guestFQDN']


-- 
To view, visit https://gerrit.ovirt.org/39299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2917de42b76ee3dc8b27bdc23b33f3c984a7cc68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list