Change in vdsm[master]: virt: make _initVmStats public

danken at redhat.com danken at redhat.com
Fri Mar 27 11:18:46 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: make _initVmStats public
......................................................................


virt: make _initVmStats public

A followup patch want to add an explicit stopVmStats method.
Currently, we have a private helper to start the Vm Stats Thread:
_initVmStats.

It could be surprising to have a private method to start and
a public one to stop, so this patch renames _initVmStats into
startVmStats to make the flows symmetric, with no further
changes in the code flow.

Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39036
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmApiTests.py
M vdsm/virt/vm.py
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Michal Skrivanek: Looks good to me, but someone else must approve
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/39036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list