Change in vdsm[master]: virt: keep libvirt's <driver> element

danken at redhat.com danken at redhat.com
Fri Mar 27 09:23:20 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: keep libvirt's <driver> element
......................................................................


Patch Set 6:

Francesco, sorry. I did not notice that you are not yet content with the comment. Marking such discontent with -1 is fair.

I did not find docs about it, but if vdsm does not as libvirt for a specific <driver>, libvirt applies it logic of attempting vhost and later falling back to qemu. I did not look at the code but it seems that libvirt does not report <driver> when the default (vhost) worked, but DOES report it when it was set to the non-default.

-- 
To view, visit https://gerrit.ovirt.org/39034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list