Change in vdsm[master]: virt: keep libvirt's <driver> element

fromani at redhat.com fromani at redhat.com
Fri Mar 27 09:09:31 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: keep libvirt's <driver> element
......................................................................


Patch Set 5:

Commenting code is a good step forward, but comment on line 4511 reads

  # If a driver was reported, pass it back to libvirt.

I really appreciate the good intentions, but this helps little since it translates the code -which is already pretty self-explanatory- in english

What ispuzzling me of is _why_ and _when_ this 'driver' is being reported. There is any good reason or it is just libvirt being lunatic? :)

Again, I see no reason to stop this patch, I just want to learn more about this matter.

For that, a RTFM (but with some meaningful starting point please, not just generic reference to the docs!) is fine for me.

-- 
To view, visit https://gerrit.ovirt.org/39034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list