Change in vdsm[master]: vdscliTests: add a test for connect with a timeout

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Mar 27 07:53:08 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: vdscliTests: add a test for connect with a timeout
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/38806/8/tests/functional/vdscliTests.py
File tests/functional/vdscliTests.py:

Line 26: from vdsm import vdscli
Line 27: 
Line 28: 
Line 29: class ConnectTest(TestCaseBase):
Line 30: 
We have 2 tests run for useSSL true and false. Please use permutations and get rid of code duplication.
Line 31:     @ValidateRunningAsRoot
Line 32:     def testTimeoutSafeTransport(self):
Line 33:         c = vdscli.connect(useSSL=True,
Line 34:                            tsPath='/etc/pki/vdsm',


-- 
To view, visit https://gerrit.ovirt.org/38806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list