Change in vdsm[master]: iscsi: Fix minimal timeout when performing scsi scan

fromani at redhat.com fromani at redhat.com
Fri Mar 27 07:21:27 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: iscsi: Fix minimal timeout when performing scsi scan
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/39256/2//COMMIT_MSG
Commit Message:

Line 13: can see that we wait for about 12 milliseconds instead of 2 seconds.
Line 14: 
Line 15: Without the minimal wait, creating a storage domain may fail after
Line 16: disconnecting and reconnecting from the storage server, and trying to
Line 17: access the vg before the multiapth device was created.
typo: should be multipath
Line 18: 
Line 19: The root cause is commit 66c24c1996 (iscsi: Iscsi rescan cleanup), which
Line 20: replaced blocking scsi scan and interrupt-safe wait loop with
Line 21: non-blocking scsi scan and single unsafe time.sleep().


-- 
To view, visit https://gerrit.ovirt.org/39256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c62ed29c67698d689f8a345e6a740363c77c0d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list