Change in vdsm[master]: virt: introduce support for periodic operations

fromani at redhat.com fromani at redhat.com
Thu Mar 26 15:36:39 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: introduce support for periodic operations
......................................................................


Patch Set 24:

(2 comments)

https://gerrit.ovirt.org/#/c/37593/24/tests/periodicTests.py
File tests/periodicTests.py:

Line 115:         op = periodic.Operation(_work, period=PERIOD,
Line 116:                                 scheduler=self.sched,
Line 117:                                 executor=self.exc)
Line 118:         op.start()
Line 119:         time.sleep(PERIOD + PERIOD)
> funny way of writing 2 * PERIOD
Done
Line 120:         # avoid pathological case on which nothing ever runs
Line 121:         self.assertTrue(invokations[0] > 0)
Line 122: 
Line 123:         op.stop()


Line 122: 
Line 123:         op.stop()
Line 124:         stop = monotonic_time()
Line 125: 
Line 126:         time.sleep(PERIOD)  # gracetime
> gracetime? It seems more like the opposite: time that we let the scheduler 
Right, is more like a cool down time. Will fix the comment.
Line 127: 


-- 
To view, visit https://gerrit.ovirt.org/37593
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list