Change in vdsm[master]: RFE: Report downtime for each live migration
vfeenstr at redhat.com
vfeenstr at redhat.com
Thu Mar 26 08:46:12 UTC 2015
Vinzenz Feenstra has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3051: self.log.info("End of migration")
Line 3052:
Line 3053: def _getActualDowntime(self):
Line 3054: stat = self._dom.jobStats(libvirt.VIR_DOMAIN_JOB_STATS_COMPLETED)
Line 3055: if 'downtime' in stat:
the whole if/else portion can be simplified to one line:
self._actualDowntime = stat.get('downtime', None)
Line 3056: self._actualDowntime = stat['downtime']
Line 3057: else:
Line 3058: self._actualDowntime = None
Line 3059:
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list