Change in vdsm[master]: stomp: parsing buffer refactoring
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Thu Mar 26 08:06:52 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/38666/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 423: self._update_outgoing_heartbeat()
Line 424: self._outgoing_heartbeat_in_milis = outgoing
Line 425:
Line 426: def handle_connect(self, dispatcher):
Line 427: self._outbuf = None
> this is not related. please post in separate patch and explain why we need
Will push it as separate patch and give explanation.
Line 428: self._frameHandler.handle_connect(self)
Line 429:
Line 430: def handle_read(self, dispatcher):
Line 431: try:
--
To view, visit https://gerrit.ovirt.org/38666
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list