Change in vdsm[master]: stomp: client side subscription

ybronhei at redhat.com ybronhei at redhat.com
Thu Mar 26 07:01:13 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: client side subscription
......................................................................


Patch Set 11: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/36368/11//COMMIT_MSG
Commit Message:

Line 7: stomp: client side subscription
Line 8: 
Line 9: When connecting to the server we need to send subscribe frame to receive
Line 10: messages.
Line 11: 
can you explain more what is done by this patch - removing client, jsonrpcClient - removing timeout (why?), adding outbox queue (how should it work?) and how asyncClient should work?
Line 12: Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71


https://gerrit.ovirt.org/#/c/36368/11/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 164: 
Line 165:         result = obj.get("result")
Line 166:         error = obj.get("error")
Line 167: 
Line 168:         reqId = obj.get("id")
why don't  you need to check here -

if not isinstance(reqId, (str, unicode, int)):

?
Line 169: 
Line 170:         return JsonRpcResponse(result, error, reqId)
Line 171: 
Line 172: 


-- 
To view, visit https://gerrit.ovirt.org/36368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list