Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue

barumuga at redhat.com barumuga at redhat.com
Thu Mar 26 02:12:04 UTC 2015


Bala.FA has posted comments on this change.

Change subject: gluster: fix build error in F20 due to blivet version issue
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/38942/10/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 250: 
Line 251:     stripeSize = raidParams.get('stripeSize', 0) / 1024.0
Line 252:     # bz#1198568: The latest version of blivet does not accepts float
Line 253:     # value for peSize in LVMVolumeGroupDevice function.
Line 254:     # It will be enhanced once the support is available in blivet.
> Below i am passing Size object (which may contain any float value) to _crea
OK.

If f20 and f21 blivet supports int value, why can't you pass int till the bz get fixed fully?
Line 255:     if stripeSize and supportSizeObj:
Line 256:         stripeSize = size.Size("%s MiB" % stripeSize)
Line 257:     vg = _createVG(vgName, pvDeviceList, stripeSize)
Line 258: 


-- 
To view, visit https://gerrit.ovirt.org/38942
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list