Change in vdsm[master]: migration: remove getVmStats before migration

ykaplan at redhat.com ykaplan at redhat.com
Wed Mar 25 17:42:37 UTC 2015


Yeela Kaplan has uploaded a new change for review.

Change subject: migration: remove getVmStats before migration
......................................................................

migration: remove getVmStats before migration

Calling getVmStats before migration to check if the
same vm exists on the destination host is redundant.
If it does, then our system is in much bigger trouble
and migration will fail anyway.
and if the connection was not established we will fail
in the next step of the migration anyway.

Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
---
M vdsm/virt/migration.py
1 file changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/39202/1

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index c2a112e..c50fbb4 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -118,15 +118,6 @@
         else:
             self.destServer = kaxmlrpclib.Server('http://' + hostPort)
         self.log.debug('Destination server is: ' + hostPort)
-        try:
-            self.log.debug('Initiating connection with destination')
-            status = self.destServer.getVmStats(self._vm.id)
-            if not status['status']['code']:
-                self.log.error("Machine already exists on the destination")
-                self.status = errCode['exist']
-        except Exception:
-            self.log.exception("Error initiating connection")
-            self.status = errCode['noConPeer']
 
     def _setupRemoteMachineParams(self):
         self._machineParams.update(self._vm.status())


-- 
To view, visit https://gerrit.ovirt.org/39202
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list