Change in vdsm[master]: misc: Safer and simpler itmap

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 25 17:15:21 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: misc: Safer and simpler itmap
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/39119/6/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 918:         t.daemon = True
Line 919:         t.start()
Line 920:         values.put(DONE)
Line 921: 
Line 922:     for _ in xrange(count):
> maybe you forgot an 'xrange' here (should be 'range')
count may be big, so we should use xrange on Python 2.
Line 923:         yield results.get()
Line 924: 
Line 925: 
Line 926: def isAscii(s):


-- 
To view, visit https://gerrit.ovirt.org/39119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list