Change in vdsm[master]: virt: configurable sampling interval for HostStatsThread

danken at redhat.com danken at redhat.com
Wed Mar 25 17:03:57 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: configurable sampling interval for HostStatsThread
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39191/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 171:             'How often should we sample NUMA CPU assignments'),
Line 172: 
Line 173:         ('host_sample_stats_interval', '15', None),
Line 174: 
Line 175:         ('host_sample_stats_window', '5', None),
> As far as I see, *_window is always exposed in pair with *_interval, except
This is a historical mistake that I'd like to fix. Since Engine polls stats every 15s we don't need finer measurements, and no need to keep intermediate measurements. window=2 should be kept hard coded.
Line 176: 
Line 177:         ('trust_store_path', '@TRUSTSTORE@',
Line 178:             'Where the certificates and keys are situated.'),
Line 179: 


-- 
To view, visit https://gerrit.ovirt.org/39191
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I526029a6a45a928fd0af2f320fe64ac842e205a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list