Change in vdsm[master]: virt: keep libvirt's <driver> element

danken at redhat.com danken at redhat.com
Wed Mar 25 16:07:08 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: keep libvirt's <driver> element
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/39034/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4471:         for x in self._domain.get_device_elements('interface'):
Line 4472:             devType = x.getAttribute('type')
Line 4473:             mac = x.getElementsByTagName('mac')[0].getAttribute('address')
Line 4474:             alias = x.getElementsByTagName('alias')[0].getAttribute('name')
Line 4475:             driver = x.getElementsByTagName('driver')
I'd prefer extra care regarding types. Here, driver is a possibly-empty list. Two lines below, it's dict.

calling the temporary name differently (drivers? xdrivers?) clutters the namespace, but avoids future confusions.
Line 4476:             if driver:
Line 4477:                 driver = {'name': driver[0].getAttribute('name'),
Line 4478:                           'queues': driver[0].getAttribute('queues')}
Line 4479:             if devType == 'hostdev':


-- 
To view, visit https://gerrit.ovirt.org/39034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list