Change in vdsm[master]: virt: net: getXML: supply alias when known

fromani at redhat.com fromani at redhat.com
Wed Mar 25 15:09:39 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: net: getXML: supply alias when known
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38880/2/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:

Line 95:         </interface>
Line 96:         """
Line 97:         iface = self.createXmlElem('interface', self.device, ['address'])
Line 98:         if getattr(self, 'alias', None) is not None:
Line 99:             iface.appendChildWithArgs('alias', name=self.alias)
> To settle this, you can modify or extendtests/deviceTests.py :: testInterfa
Done
Line 100: 
Line 101:         iface.appendChildWithArgs('mac', address=self.macAddr)
Line 102:         iface.appendChildWithArgs('model', type=self.nicModel)
Line 103:         iface.appendChildWithArgs('source', bridge=self.network)


-- 
To view, visit https://gerrit.ovirt.org/38880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a881144514ad8abbd0b1d3e4e2bc877b0e88c9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list