Change in vdsm[master]: stomp: parsing buffer refactoring

ybronhei at redhat.com ybronhei at redhat.com
Wed Mar 25 11:58:09 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: parsing buffer refactoring
......................................................................


Patch Set 6: Code-Review-1

I don't understand why not to use StringIO . please explain how default string handles the buffer better. StringIO allows compression, should be faster and provider the same API

-- 
To view, visit https://gerrit.ovirt.org/38666
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list