Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue

tjeyasin at redhat.com tjeyasin at redhat.com
Wed Mar 25 08:00:29 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: fix build error in F20 due to blivet version issue
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/38942/8/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 252:     # with "ValueError: invalid value Not Implemented for size" error.
Line 253:     # at the end of vg create execution.
Line 254:     # So it is need to pass a size object for the latest version of
Line 255:     # vg create function and a numerical value for the older version of
Line 256:     # vg create.
> Actually passing size object is more good than numerical value because size
Blivet Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1198568
Line 257:     if stripeSize and isinstance(pvDeviceList[0].size, size.Size):
Line 258:         stripeSize = size.Size("%s MiB" % stripeSize)
Line 259:         supportSizeObj = True
Line 260:     vg = _createVG(vgName, pvDeviceList, stripeSize)


Line 255:     # vg create function and a numerical value for the older version of
Line 256:     # vg create.
Line 257:     if stripeSize and isinstance(pvDeviceList[0].size, size.Size):
Line 258:         stripeSize = size.Size("%s MiB" % stripeSize)
Line 259:         supportSizeObj = True
> Bala, I am waiting for your reply!
I got it now and sent the updated patch
Line 260:     vg = _createVG(vgName, pvDeviceList, stripeSize)
Line 261: 
Line 262:     # The following calculation is based on the redhat storage performance doc
Line 263:     # http://docbuilder.usersys.redhat.com/22522


-- 
To view, visit https://gerrit.ovirt.org/38942
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list