Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue

tjeyasin at redhat.com tjeyasin at redhat.com
Wed Mar 25 07:31:13 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: fix build error in F20 due to blivet version issue
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/38942/8/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 252:     # with "ValueError: invalid value Not Implemented for size" error.
Line 253:     # at the end of vg create execution.
Line 254:     # So it is need to pass a size object for the latest version of
Line 255:     # vg create function and a numerical value for the older version of
Line 256:     # vg create.
> This sounds like a bug in blivet - why are you trying to fix blivet bugs in
Actually passing size object is more good than numerical value because size object will have more clarity. Also in the higher version using just a numerical value is depreciated and not recommended.  So its good to use size object if its support otherwise we can go with only numerical value for peSize param. I can remove this or enhance this part later once blivet fixes this issue.
Line 257:     if stripeSize and isinstance(pvDeviceList[0].size, size.Size):
Line 258:         stripeSize = size.Size("%s MiB" % stripeSize)
Line 259:         supportSizeObj = True
Line 260:     vg = _createVG(vgName, pvDeviceList, stripeSize)


Line 276:         # The latest blivet version accept a numerical value or size object
Line 277:         # for lv size and creates a lv map/obj in memory, however it fails
Line 278:         # with an "unsupported operand type" error at the end of execution.
Line 279:         # The lower version of blivet expects the lv size to be given as a
Line 280:         # numerical MiB value.
> This sounds like a bug in blivet - why are you trying to fix blivet bugs in
Actually I want to use only size object because it will give more clarity about the value and can be converted easily. I will send enhancement later once blivet fixes the issue.
Line 281:         # So it is required to pass the value as a size obj for the latest
Line 282:         # one and its needed to pass numeric value for the older version to
Line 283:         # support backward compatibility.
Line 284:         if supportSizeObj:


-- 
To view, visit https://gerrit.ovirt.org/38942
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list