Change in vdsm[master]: Introducing getAvailableUpdates API
dkuznets at redhat.com
dkuznets at redhat.com
Tue Mar 24 13:59:36 UTC 2015
Dima Kuznetsov has posted comments on this change.
Change subject: Introducing getAvailableUpdates API
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38559/5/vdsm/API.py
File vdsm/API.py:
Line 1309: info['updates'] = []
Line 1310: with open(constants.P_VDSM_LIB + 'updates.list', 'r') as f:
Line 1311: for line in f:
Line 1312: pkg = {}
Line 1313: line = line.split('#')
Any reason for serializing manually? Why not some JSON/other format that will just yield this dictionary?
Line 1314: pkg['name'] = line[0]
Line 1315: pkg['version'] = line[1]
Line 1316: pkg['prev_version'] = line[2]
Line 1317: pkg['repo'] = line[3]
--
To view, visit https://gerrit.ovirt.org/38559
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list