Change in vdsm[master]: virt: introduce support for periodic operations
fromani at redhat.com
fromani at redhat.com
Tue Mar 24 13:27:47 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: virt: introduce support for periodic operations
......................................................................
Patch Set 20:
(2 comments)
https://gerrit.ovirt.org/#/c/37593/20/tests/periodicTests.py
File tests/periodicTests.py:
Line 58: scheduler=self.sched,
Line 59: executor=self.exc)
Line 60: op.start()
Line 61: time.sleep(0.1) # let other thread run
Line 62: self.assertEqual(self._invokations, 1)
> An event would probably better
Done
Line 63:
Line 64: def test_start_twice(self):
Line 65: op = periodic.Operation(self._work, period=1.0,
Line 66: scheduler=self.sched,
Line 76: executor=self.exc)
Line 77: op.start()
Line 78: time.sleep(PERIOD * TIMES)
Line 79: op.stop()
Line 80: self.assertTrue(TIMES <= self._invokations <= TIMES + 1)
> Same: let's try with events
Done
Line 81:
Line 82: def test_stop(self):
Line 83: PERIOD = 0.1
Line 84: op = periodic.Operation(self._work, period=PERIOD,
--
To view, visit https://gerrit.ovirt.org/37593
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list