Change in vdsm[master]: gluster: Corrected return value of gluster volume snapshot c...

shtripat at redhat.com shtripat at redhat.com
Tue Mar 24 12:45:05 UTC 2015


Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: Corrected return value of gluster volume snapshot create
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/39075/3/vdsm.spec.in
File vdsm.spec.in:

Line 276: Requires
> Would this be available in the gluster repo?
This change was suggested by Darshan as he has in his patch as well. I think any rpm version which is greater than 3.6.999 (e.g. 3.7) would work with this.


https://gerrit.ovirt.org/#/c/39075/3/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1274: find
> Is creationtime also returned by gluster?
No. Currently we set as current date of engine as creation time. if snapshot is created from CLI it gets as part of sync.


https://gerrit.ovirt.org/#/c/39075/3/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:

Line 1673: of
> update the comment?
done


-- 
To view, visit https://gerrit.ovirt.org/39075
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22441d90291be5cb8aa0d5498021b9e9a678adfc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list